You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DualNumbers has been a direct dependency of this package for about as long as this package has tracked its dependencies. Methods of some internal functions are defined for Dual but dual numbers don't seem to actually be used. As far as I can tell, it would be a non-functional change from this package's perspective to remove the dependency and the methods. That said, I don't know whether there was a reason (e.g. integration with some other specific downstream package) that these methods are defined for Dual. If it's important to have those methods defined, they could potentially be moved to an extension (for Julia 1.9+), or otherwise perhaps the dependency can be removed altogether.
The text was updated successfully, but these errors were encountered:
Pro: it's reasonable to remove superfluous dependencies. (I'm always in favour of that!)
Con: #59 would result in code duplication elsewhere.
And: the using and compilation times of this package are dominated by SpecialFunctions, notDualNumbers.
Looking at #59, it seems that continuing support in SingularIntegralEquations.jl would require duplicating the methods that are no longer declared for Dual128 and DualComplex256, which is not ideal for maintenance.
dlfivefifty
changed the title
Remove DualNumbers or make it a weak dependency?
Make DualNumbers a weak dependency
Jul 30, 2023
DualNumbers has been a direct dependency of this package for about as long as this package has tracked its dependencies. Methods of some internal functions are defined for
Dual
but dual numbers don't seem to actually be used. As far as I can tell, it would be a non-functional change from this package's perspective to remove the dependency and the methods. That said, I don't know whether there was a reason (e.g. integration with some other specific downstream package) that these methods are defined forDual
. If it's important to have those methods defined, they could potentially be moved to an extension (for Julia 1.9+), or otherwise perhaps the dependency can be removed altogether.The text was updated successfully, but these errors were encountered: