MeasureBase 0.14 + other updates #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
Closed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
- Coverage 45.98% 45.09% -0.89%
==========================================
Files 43 43
Lines 1344 1346 +2
==========================================
- Hits 618 607 -11
- Misses 726 739 +13
☔ View full report in Codecov by Sentry. |
|
|
@gaurav-arya Since you brought this up, I've invited you to the repo in case you'd like to review. @mschauer I've also requested a review if you're available in case you have thoughts on this. It's a small PR so hopefully quick to review :) |
|
gaurav-arya
approved these changes
Aug 22, 2023
|
Thanks @gaurav-arya . I've merged this branch into #240, which has some other changes we had planned. Once we're set here we can close this PR and merge that one instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix to get MeasureTheory working with the latest MeasureBase (currently v0.14). Note that some tests have been removed; these will be reworked and added to MeasureBase.jl.
Addresses #259