-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MOI wrapper #929
Add MOI wrapper #929
Conversation
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
- Coverage 85.29% 84.93% -0.36%
==========================================
Files 43 44 +1
Lines 3202 3405 +203
==========================================
+ Hits 2731 2892 +161
- Misses 471 513 +42
|
Thanks, this seems like a lot of work you've done. I'll review it |
@pkofod I just updated it to MOI v1. Could you get a look ? |
Bump :) |
Sorry, I had not noticed any of these bumps. |
One of the questions of this talk: https://meetings.siam.org/sess/dsp_talk.cfm?p=129039 was whether Optim could be used from JuMP |
Optimization.jl wraps both Optim.jl and the JuMP methods (through MOI), so it effectively achieves the same goal. |
I dont see how it is the same goal. |
want to get it finished if I promise to review and get it in this time? :) |
You are way too patient. Thanks @blegat ! |
With this MOI wrapper, one should be able to use Optim with JuMP doing:
If there are nonlinear constraints created with
@NLconstraint
, it would selectIPNewton
.Otherwise, this would select the method using
fallback_method
which is wrapped inFminbox
if there are variable bounds.The objective need to be created with
@NLobjective
.Note: Quadratic and affine objective created with
@objective
and constraints created with@constraint
are not supported directly by the wrapper but it might be usable with Optim without the need to change anything in this wrapper with the idea suggested in jump-dev/MathOptInterface.jl#1397This addresses the third item of #609