Update GH actions + add dependabot #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
reviewed
Aug 30, 2024
.github/workflows/ci.yml
Outdated
| - 1.6 # LTS | ||
| - lts |
There was a problem hiding this comment.
We can't require lts in project.toml, right? So I think an explicit version in CI might be better.
There was a problem hiding this comment.
That's a good point. Ideally, I guess one would want to test the oldest supported version and LTS - the first could be hardcoded (since one has to update the Project.toml manually anyway when changing it) and the second achieved with the lts option. But it's unnecessarily many tests if both coincide...
jw3126
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates the GH actions, adds dependabot (to keep them updated automatically),
and uses.ltsinstead of 1.6 as a more stable way to test LTS versions