Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set_preferences!(name::String, ...) method which pulls UUID from Project.toml #62

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

staticfloat
Copy link
Member

@staticfloat staticfloat commented Nov 11, 2023

This makes it much more convenient to set preferences as previously you either had to know (1) the UUID or (2) have the Module handy, and sometimes you don't want to load an entire package just to set a preference for it.

@staticfloat staticfloat changed the title Add set_preferences!(name::String, ...) method which pulls UUID fro… Add set_preferences!(name::String, ...) method which pulls UUID from Project.toml Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.96%. Comparing base (ae3184a) to head (5aac59c).

Files Patch % Lines
src/utils.jl 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   88.05%   90.96%   +2.90%     
==========================================
  Files           2        2              
  Lines         134      155      +21     
==========================================
+ Hits          118      141      +23     
+ Misses         16       14       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@staticfloat
Copy link
Member Author

Nightly failures look like a Pkg bug, unfortunately.

@3f6a
Copy link

3f6a commented Feb 28, 2024

Just a friendly ping, since this would be quite convenient, and looks ready to merge?

…m `Project.toml`

This makes it much more convenient to set preferences as previously you
either had to know (1) the `UUID` or (2) have the `Module` handy, and
sometimes you don't want to load an entire package just to set a
preference for it.
@staticfloat staticfloat merged commit c8e070a into master Feb 28, 2024
14 of 19 checks passed
@giordano giordano deleted the sf/no_load_preference_setting branch February 28, 2024 18:15
@3f6a
Copy link

3f6a commented Feb 28, 2024

Could we get a release with this? Thanks!

@aviatesk
Copy link
Contributor

Would it be more convenient if we also added similar extensions for [has|load|delete]_preference?

aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Feb 29, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Feb 29, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Feb 29, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
staticfloat added a commit that referenced this pull request Mar 3, 2024
follow up #62, fix the error of `get_uuid` in the active project lookup path
aviatesk added a commit to aviatesk/Preferences.jl that referenced this pull request Mar 3, 2024
Extends the enhancement for `set_preferences!` added in JuliaPackaging#62 to the other
functionalities too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants