-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Russian translation #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, this is great to have!
You also need to "register" Russian by adding it here: PlutoTeachingTools.jl/src/i18n/i18n.jl Lines 55 to 82 in 2733205
and possibly add it to the example as well: PlutoTeachingTools.jl/example.jl Line 25 in 2733205
|
Example notebook seems to work correctly, sorry about force-pushing. |
Thanks! |
Thank you for quick merge, any chance of pushing that to the registry? |
Yes, I was hoping for a quick approval of #47, but I'll just go ahead and merge it. |
Your contribution should appears in v0.3.0 in the general registry soon. |
@kagalenko-m-b, Could you add the Rusian text for the multi-language demonstration in the example notebook? |
Sure, no problem, but it seems this would require some infrastructure for switching texts that is not at the moment there. |
For me, the Russian translation works in the example notebook. Just make sure to use the latest PlutoTeachingTools |
It works for the titles of boxes, I thought that @eford had been talking about the main text. |
Yes, I was thinking of here |
https://github.com/JuliaPluto/PlutoTeachingTools.jl/pull/56/files |
Russian-language strings for functions in "computational_thinking.jl"