-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize columns
#51
Conversation
@fonsp Is |
6926d24
to
72cd913
Compare
06df789
to
fc1d44b
Compare
|
Hey all! Yes you can use it, and you should use it! I think I will eventually put it in a separate package, but I will make sure that PlutoTeachingTools does not break (it is API included in PlutoUI semver). |
Ah sorry I did not look at the code properly: Using PlutoRunner as a dependency will not work, but you can use |
About the change in layout: I highly recommend using I'm sure that the difference in size with text boxes can be fixed using the new code, maybe you could share a screenshot to show the difference that you notice? Having both methods in the same package might be quite confusing when users try to make these more complex layouts with interactive elements and such. |
thanks @fonsp It works now as intended. (I had too many |
@@ -1,5 +1,6 @@ | |||
module PlutoTeachingTools | |||
|
|||
using PlutoUI.ExperimentalLayout: Div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use using
here instead of import
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should only use import
if you extend a function.
(This consistent with the rest of the package.)
@eford do you approve these changes? If so, I'd merge and tag a new release so that I can use these changes for my course material. (These changes are a strict improvement. The problem about width of boxes was solved.) |
Thanks. Merged from phone. I can do a new version later today. |
Thanks, I've registered a new version. |
closes #37. This is based on @fonsp 's suggestion in #37.
You can now display any number of columns using
Columns(a, b, c, d, e)
. Columns will have equal width by default.You can change the width using
Columns(a, b, c, widths = [30, 20, 50])
(widths
will be normalized to sum to 100 internally), and you can also customize the gap between columns.Unfortunately, I couldn't figure out how to make text boxes fill the whole column:
The warning box is just as wide as the text.
Any ideas how to make the box fill up the whole column?