Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CondaPkg dependency for Extension package #160

Open
wsmoses opened this issue Dec 20, 2024 · 3 comments
Open

CondaPkg dependency for Extension package #160

wsmoses opened this issue Dec 20, 2024 · 3 comments

Comments

@wsmoses
Copy link

wsmoses commented Dec 20, 2024

I'm hoping to add a python dependency to an extension package, and it wasn't clear to me how this should be done.

Any tips?

x/ref EnzymeAD/Reactant.jl#354 EnzymeAD/Reactant.jl#407

cc @mofeing @avik-pal

@mofeing
Copy link

mofeing commented Dec 20, 2024

i guess that just adding CondaPkg.toml suffices? https://github.com/JuliaPy/PythonPlot.jl/blob/main/CondaPkg.toml

my hope is that this works when PythonCall/CondaPkg is a weak dep

@wsmoses
Copy link
Author

wsmoses commented Dec 20, 2024

yeah the problem is we don't want to add the condapkg.toml on Reactant itself, but only when the PythonCall extension is loaded....and that....I have no idea how to do

@mofeing
Copy link

mofeing commented Dec 20, 2024

i guess that it'll still work? like CondaPkg.toml will only be checked when CondaPkg is loaded (or precompiled?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants