Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Codecov integration #16

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

fingolfin
Copy link
Member

@fingolfin fingolfin commented May 10, 2023

Also update some actions to their latest version.

Note that this may require additional admin action, e.g.
adding / enabling the Codecov integration from the GitHub
marketplace for this repository.

@fingolfin
Copy link
Member Author

Let's re-run jobs based on lastest master

@fingolfin
Copy link
Member Author

The log report an error, which is also visible at https://app.codecov.io/github/JuliaRandom/RandomExtensions.jl:

This repo has been deactivated
Contact an administrator of your git organization to grant write-permissions in your git-provider for this repository.

I suppose someone with the right access level has to go to https://github.com/JuliaRandom/RandomExtensions/settings/installations and verify the Codecov is there, and enabled for this repo.

@fingolfin fingolfin closed this Oct 9, 2023
@fingolfin fingolfin reopened this Oct 9, 2023
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@fingolfin fingolfin closed this Oct 9, 2023
@fingolfin fingolfin reopened this Oct 9, 2023
@fingolfin
Copy link
Member Author

OK, https://app.codecov.io/gh/JuliaRandom/RandomExtensions.jl shows data again (go to the "Pulls" tab). Once this is merged (better: squashed) it should also show data again on the front, for master.

I'll not merge this immediately as @rfourquet wanted to check something -- maybe that was just about checking why it didn't work (which should be resolved now), but maybe there was something else?

Also update some actions to their latest version
@rfourquet
Copy link
Member

but maybe there was something else?

Yeah I wanted to look more into this coverage topic, to understand the options. I still didn't find a lot of online resources about this, is codecov essentially about reporting coverage information on PRs? I can see the appeal, but for example in this very PR codecov comments are unrelated, so it seems noisy... I'm open to try it out though.

Are there other options people use for tracking coverage, beside the built-in --code-coverage CLI option? maybe Coveralls? I also saw Coverage.jl.

@fingolfin
Copy link
Member Author

Codecov is the only one that reliably works in my experience. Coveralls exists but I never got it to work reliably nor have I seen it work reliably on other projects.

but for example in this very PR codecov comments are unrelated, so it seems noisy.

Well, yeah, they point out things that are not covered -- they do so because there is no baseline data for master... Once this is merged, I don't think this noise won't show up for future PRs. (That said, the issue is relevant: it points to code that is not triggered by any tests in this package(

I am not quite sure what you are concerned about, though -- in the worst case this can be removed again later? But to see useful data, this needs to be merged first (so there is a baseline), and then you can experience the effect on future PRs.

@fingolfin
Copy link
Member Author

Oh, and Coverage.jl is what is used here, but it uses coverage data via the builtin --code-coverage, and can then process it for use in various ways -- for upload to Codecov or Coveralls, or also manual inspection with profiling tools that support parsing e.g. lcov files. But local, manual coverage analysis != automatic coverage analysis for PRs, with online reports on uncovered code. This is only offered by Codecov and Coveralls. And AFAIK only Codecov can annotate PRs to point at uncovered code.

@rfourquet
Copy link
Member

Ok thanks for your comments, let's try it out

@rfourquet rfourquet merged commit 0de478c into JuliaRandom:master Oct 10, 2023
12 checks passed
@fingolfin fingolfin deleted the mh/codecov branch October 10, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants