Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakage with latest Julia nightly #17

Closed
fingolfin opened this issue Oct 7, 2023 · 2 comments · Fixed by #18
Closed

Breakage with latest Julia nightly #17

fingolfin opened this issue Oct 7, 2023 · 2 comments · Fixed by #18

Comments

@fingolfin
Copy link
Member

Recent changes (from the past 24 hours or so, as I did not see this a few hours ago) on Julia master seem to have broken this package (@rfourquet ...?)

WARNING: Method definition (::Type{Random.Sampler{E} where E})(Type{RNG}, Type{Pair{A, B}}, Union{Base.Val{1}, Base.Val{inf}}) where {RNG<:Random.AbstractRNG, A, B} in module Random at /cache/build/default-amdci5-4/julialang/julia-master/usr/share/julia/stdlib/v1.11/Random/src/generation.jl:187 overwritten in module RandomExtensions at /home/runner/.julia/packages/RandomExtensions/qAD6J/src/sampling.jl:209.
ERROR: LoadError: Method overwriting is not permitted during Module precompile.
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/RandomExtensions/qAD6J/src/sampling.jl:209
 [2] include(mod::Module, _path::String)
   @ Base ./Base.jl:497
 [3] include(x::String)
   @ RandomExtensions ~/.julia/packages/RandomExtensions/qAD6J/src/RandomExtensions.jl:1
 [4] top-level scope
   @ ~/.julia/packages/RandomExtensions/qAD6J/src/RandomExtensions.jl:48
 [5] include
   @ Base ./Base.jl:497 [inlined]
 [6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
   @ Base ./loading.jl:2270
 [7] top-level scope
   @ stdin:3
in expression starting at /home/runner/.julia/packages/RandomExtensions/qAD6J/src/sampling.jl:209
in expression starting at /home/runner/.julia/packages/RandomExtensions/qAD6J/src/RandomExtensions.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile RandomExtensions [fb686558-2515-59ef-acaa-46db3789a887] to "/home/runner/.julia/compiled/v1.11/RandomExtensions/jl_sDFnMX".
@fingolfin
Copy link
Member Author

This may have been caused by the merge of JuliaLang/julia#28705

@simeonschaub
Copy link

This seems to be due to this package pirating methods in Random, so those definitions will need to be removed:

Sampler(::Type{RNG}, ::Type{Pair{A,B}}, n::Repetition) where {RNG<:AbstractRNG,A,B} =

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants