Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error tolerance should be compared using <= instead of < #567

Closed
schillic opened this issue Aug 20, 2018 · 0 comments
Closed

Error tolerance should be compared using <= instead of < #567

schillic opened this issue Aug 20, 2018 · 0 comments
Assignees
@schillic
Labels
bug 🐛 Something isn't working

Comments

@schillic
Copy link
Member

We define const TOL(N::Type{Rational{INNER}}) where {INNER} = zero(N). During iterative refinement, we compare two vectors with norm(p1-p2, 2) < TOL(N). This will always result in false. However, we want to terminate in the case p1 == p2.
@schillic schillic added the bug 🐛 Something isn't working label Aug 20, 2018
@schillic schillic self-assigned this Aug 20, 2018
@schillic schillic mentioned this issue Aug 20, 2018
Merged
schillic added a commit that referenced this issue Aug 21, 2018
@schillic
Merge pull request #568 from JuliaReach/schillic/567
21074f6 
#567 - Error tolerance should be compared using <= instead of <
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schillic schillic

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schillic