Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ForceConstants v0.1.4 #116783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 7, 2024

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaRegistrator JuliaRegistrator force-pushed the registrator-forceconstants-58688e27-v0.1.4-8284d5a514 branch from 0eb99be to 809cbd6 Compare October 7, 2024 19:35
JuliaRegistrator referenced this pull request in ejmeitz/ForceConstants.jl Oct 7, 2024
add compat entries
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-forceconstants-58688e27-v0.1.4-8284d5a514 branch from 809cbd6 to 8eea124 Compare October 7, 2024 20:01
UUID: 58688e27-5ad4-4797-95f1-2920f5d19b53
Repo: https://github.com/ejmeitz/ForceConstants.jl.git
Tree: b55db33d7c054948dfa0f18fc4e62484fc811399

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-forceconstants-58688e27-v0.1.4-8284d5a514 branch from 8eea124 to 1d2ef1e Compare October 7, 2024 20:13
JuliaRegistrator referenced this pull request in ejmeitz/ForceConstants.jl Oct 7, 2024
@goerz
Copy link
Member

goerz commented Oct 9, 2024

Thank you for submitting your package! I don't see any fundamental isues with this, but I just want to double check on the description "Home of all my lattice dynamics codes written in Julia". That sounds a lot like a "personal package", which we discourage for registration in General.

It does seem like ForceConstants is a fairly general name. I don't have the necessary background to decide whether the package is "complete" in terms of its scope, "calculate interatomic force constants". Or at least, if it's heading there / will be maintained in the future. If this is just packaging up code from your PhD (especially if you are moving on), please consider whether you want to "use up" the name ForceConstants. It may not even be necessary to register the package: unregistered packages can be installed directly from GitHub, so registration is only absolutely necessary if any registered package will have ForceConstants as a dependency. You could also use a VeryLongAndDistinctiveName, and that will receive very little scrutiny, and will not clash with future package registrations.

If you feel that your package is "complete", or if you are planning to maintain this in the long term (accepting PRs from other people interested in interatomic force constants), I don't see a problem with merging this. I'd just ask you to confirm so that I can unblock the registration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants