-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ForceConstants v0.1.4 #116783
base: master
Are you sure you want to change the base?
New package: ForceConstants v0.1.4 #116783
Conversation
JuliaRegistrator
commented
Oct 7, 2024
•
edited
Loading
edited
- Registering package: ForceConstants
- Repository: https://github.com/ejmeitz/ForceConstants.jl
- Created by: @ejmeitz
- Version: v0.1.4
- Commit: 969d90d3e04fb2ac6c5a601da764c9d06f172d0b
- Reviewed by: @ejmeitz
- Reference: ejmeitz/ForceConstants.jl@969d90d#commitcomment-147674020
- Description: Home of all my lattice dynamics codes written in Julia
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
0eb99be
to
809cbd6
Compare
add compat entries
809cbd6
to
8eea124
Compare
UUID: 58688e27-5ad4-4797-95f1-2920f5d19b53 Repo: https://github.com/ejmeitz/ForceConstants.jl.git Tree: b55db33d7c054948dfa0f18fc4e62484fc811399 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
8eea124
to
1d2ef1e
Compare
Thank you for submitting your package! I don't see any fundamental isues with this, but I just want to double check on the description "Home of all my lattice dynamics codes written in Julia". That sounds a lot like a "personal package", which we discourage for registration in General. It does seem like If you feel that your package is "complete", or if you are planning to maintain this in the long term (accepting PRs from other people interested in interatomic force constants), I don't see a problem with merging this. I'd just ask you to confirm so that I can unblock the registration. |