Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GPU support? #8

Closed
darsnack opened this issue Mar 2, 2022 · 2 comments · Fixed by #9
Closed

Allow GPU support? #8

darsnack opened this issue Mar 2, 2022 · 2 comments · Fixed by #9

Comments

@darsnack
Copy link
Contributor

darsnack commented Mar 2, 2022

The current type for CircularArrayBuffer only allows the backing array to be an Array. Can this be relaxed to allow CuArrays (or any AbstractArray)? AFAICT scalar indexing is not introduced by the package code (meaning scalar indexing should only trigger if a user is scalar indexing in the first place).

You might also consider adding an Adapt.jl rule:

Adapt.adapt_structure(to, x::CircularArrayBuffer) =
    CircularArrayBuffer(adapt(to, x.buffer), x.first, x.nframes, x.step_size)
@findmyway
Copy link
Member

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/55949

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.6 -m "<description of version>" eacc6dc3e5299ed3a2196cfff1e105a0a1328c9f
git push origin v0.1.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants