Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need really python to generate the doc's graphs? #161

Closed
akabla opened this issue Mar 3, 2024 · 9 comments
Closed

Do we need really python to generate the doc's graphs? #161

akabla opened this issue Mar 3, 2024 · 9 comments
Assignees
Milestone

Comments

@akabla
Copy link
Member

akabla commented Mar 3, 2024

Following some investigations for issue #160 , I removed the eye candy using python and PyCall to center one of the plots. I simply placed the three plots on top of each other. It works better for mobile devices, and keeps the documentation simpler to maintain.

@alebonfanti , @moustachio-belvedere , any views?

@akabla akabla added this to the 0.9.5 milestone Mar 3, 2024
@akabla akabla self-assigned this Mar 3, 2024
@moustachio-belvedere
Copy link
Member

Looks fine to me! Thanks Alexandre

@moustachio-belvedere
Copy link
Member

BTW, I'm not sure why but there's some installation output showing in the newly built docs that wasn't there before:
https://juliarheology.github.io/RHEOS.jl/dev/examples/

@akabla
Copy link
Member Author

akabla commented Mar 3, 2024

Thanks Louis. That's new indeed.

@alebonfanti
Copy link
Member

Looks good to me as well! Thanks!

@akabla
Copy link
Member Author

akabla commented Mar 4, 2024

In fact, I'm wondering if we should not switch to Gadfly or something similar for the tutorials. It may also help with #163.

@alebonfanti
Copy link
Member

what do you think of Plots.jl?

@akabla
Copy link
Member Author

akabla commented Mar 4, 2024

Plots is great, but seems to be big - with many different backends. I was thinking about a package written in pure julia to remove dependencies as much as possible. Makie looks actually good.

@moustachio-belvedere
Copy link
Member

I don't have a preference but good to note the main advantage of PyPlot is that it is more familiar to people with a Python background

@akabla
Copy link
Member Author

akabla commented Mar 6, 2024

To note that there is also a package called PythonPlot, based on PythonCall, an alternative to PyCall.
I'm closing this as this was all triggered by issues with the doc generation, which is now working fine. We can revisit this later if needed.

@akabla akabla closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants