Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default behavior for nln_nnzj #475

Closed
sshin23 opened this issue Aug 5, 2024 · 5 comments · Fixed by #477
Closed

Default behavior for nln_nnzj #475

sshin23 opened this issue Aug 5, 2024 · 5 comments · Fixed by #477

Comments

@sshin23
Copy link

sshin23 commented Aug 5, 2024

Hi JSO team!

Recent change in #468 is causing errors in ExaModels.jl and MadNLP.jl, both of which only sets nnzj. I was wondering if the default behavior for nln_nnzj be made e.g., nln_nnzj = nnzj - lin_nnzj?

@amontoison
Copy link
Member

amontoison commented Aug 5, 2024

Hi Sungho!

We will have a similar issue if the user only provides nln_nnzj.
I'm wondering if the best solution is not to fix it in MadNLP.jl and ExaModels.jl like you did.

cc @tmigot

This was referenced Aug 5, 2024
@tmigot
Copy link
Member

tmigot commented Aug 5, 2024

Even though I agree with @amontoison , it makes sense to me that user not implementing the linear API shouldn't have to specify nln_nnzj. We could update version 0.21.2 with #477 if you both agree.

@sshin23
Copy link
Author

sshin23 commented Aug 5, 2024

@tmigot I agree that user not implementing the linear API shouldn't have to specify nln_nnzj. From the user's perspective, it will be a net improvement. Of course, there's something I'm missing; we will respect NLPModels.jl dev's decision. For now, we can remove NLPModels.jl v0.21 from the compat entry of MadNLP and ExaModels

@tmigot
Copy link
Member

tmigot commented Aug 6, 2024

@sshin23 released 21.3 should fix your issue

@sshin23
Copy link
Author

sshin23 commented Aug 6, 2024

Thanks, @tmigot and @amontoison

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants