Compare jprod default and with jacobian structure

[tmigot]

In lines

NLPModelsTest.jl/src/nlp/consistency.jl

Line 456 in 476e47c

@test isapprox(Jps[i], tmp_m, atol = rtol * max(Jmin, 1.0))

and

NLPModelsTest.jl/src/nlp/consistency.jl

Line 549 in 476e47c

@test isapprox(Jtps[i], tmp_n, atol = rtol * max(Jmin, 1.0))

we compare the usual jtprod!(nlp, x, jtv) with jtprod!(nlps[i], rows, cols, vals, w, tmp_n).

However, the results may differ (in the order of the returned vector), since some models re-implement jac_structure and jac_coord on top of jac_lin_*** and jac_nln_*** without putting the linear constraints first (for instance AmplNLReader.jl).

[dpo]

Are nlp and nlps[i] the same model (coming from the same source)? If so, the constraints should be in the same order in both.

[tmigot]

Right now, not necessarily. For instance, we will compare HS14 coming from this package https://github.com/JuliaSmoothOptimizers/NLPModelsTest.jl/blob/main/src/nlp/problems/hs14.jl and the HS14 in AmplModel format.