From 313a04f4a78bbc534f89b6b4d9c598453e2af17c Mon Sep 17 00:00:00 2001
From: Ben Corbett <32752943+corbett5@users.noreply.github.com>
Date: Thu, 22 Aug 2024 11:40:53 -0600
Subject: [PATCH] Change default QR tolerance to match SPQR (#557)

SPQR uses just the double precision epsilon even for Float32.

https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/131471310ef0600b231b8fa7c10a55c3f70afbd9/SPQR/Source/spqr_tol.cpp#L29C6-L30C57
---
 src/solvers/spqr.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/solvers/spqr.jl b/src/solvers/spqr.jl
index 3158fcdb..5f409463 100644
--- a/src/solvers/spqr.jl
+++ b/src/solvers/spqr.jl
@@ -146,7 +146,7 @@ Matrix{T}(Q::QRSparseQ) where {T} = lmul!(Q, Matrix{T}(I, size(Q, 1), min(size(Q
 
 # From SPQR manual p. 6
 _default_tol(A::AbstractSparseMatrixCSC) =
-    20*sum(size(A))*eps(real(eltype(A)))*maximum(norm(view(A, :, i)) for i in 1:size(A, 2))
+    20*sum(size(A))*eps()*maximum(norm(view(A, :, i)) for i in 1:size(A, 2))
 
 """
     qr(A::SparseMatrixCSC; tol=_default_tol(A), ordering=ORDERING_DEFAULT) -> QRSparse