Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's missing for 1.0? #1239

Closed
Datseris opened this issue Dec 14, 2020 · 9 comments
Closed

What's missing for 1.0? #1239

Datseris opened this issue Dec 14, 2020 · 9 comments

Comments

@Datseris
Copy link

Datseris commented Dec 14, 2020

Hi there,
this awesome package has been around for a really long time and is a dependency of many Julia packages but still not in 1.0. From my experience, the interface has also been "stable" for a quite a while.

What is missing? What breaking changes are planned that keep this package obtaining its first stable version? Do you have a list of these somewhere? If not, can you please state them here, or somewhere else, to give the developers that use this package an idea?

@matbesancon
Copy link
Member

@JuliaRegistrator register()

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/26483

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.24.7 -m "<description of version>" 530b9e0fe2d07e9a8082eaefdbc42fdcab3b7474
git push origin v0.24.7

@Datseris
Copy link
Author

@matbesancon I'm not sure whether I should be able to deduce something here, but I can't.

@matbesancon
Copy link
Member

@Datseris sorry no I just used the issue opened to register a version

@Datseris
Copy link
Author

Oh okay. BTW you can also tag releases by commenting on commits. I typically find this cleaner on the long term, as the comment that tags the release is directly associated the commit this release should be done on.

@drrmmng
Copy link

drrmmng commented Jan 1, 2021

Regarding the original question:
I believe this package needs more documentation.

For example, I was trying to figure out if I can backpropagate through rand with respect to the distribution parameters in Flux. That is relevant for things like variational inference. After working my way through the code I'm pretty convinced that this is possible, at least for the multivariate normal distribution.

Are there plans to improve the documentation and if so, how could I help?

@matbesancon
Copy link
Member

I will close this issue as a duplicate of #880

I believe this package needs more documentation.

Completely agreed, more and better.

For example, I was trying to figure out if I can backpropagate through rand with respect to the distribution parameters in Flux

Through other functions yes, but through rand I am not sure this is doable? rand is not even a function in the mathematical sense, or if you consider rand(rng, d), it is mutating its first argument in a non-differentiable way

@matbesancon
Copy link
Member

Are there plans to improve the documentation and if so, how could I help?

No plans yet, but whenever you see things that could be improved a PR is useful

@drrmmng
Copy link

drrmmng commented Jan 2, 2021

Through other functions yes, but through rand I am not sure this is doable? rand is not even a function in the mathematical sense, or if you consider rand(rng, d), it is mutating its first argument in a non-differentiable way

Good point! What I was trying to do with this package is called the reparameterization trick.

In case of the MvNormal distribution that seems to be possible, however, my problem was that there is nothing like a batch dimension for distribution along the line of PyTorch's distributions. This made it impossible to create a batch of MvNormal distributions by passing a 2d array, which is necessary for CUDA arrays, since they discourage scalar access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants