Stop testing on nightly #1861
Closed
Stop testing on nightly #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are so many failures that it makes the CI status useless. We should trigger CI upcoming Julia releases in dedicated PRs instead of unconditionally testing on nightly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1861 +/- ##
==========================================
- Coverage 85.99% 85.90% -0.09%
==========================================
Files 144 144
Lines 8666 8655 -11
==========================================
- Hits 7452 7435 -17
- Misses 1214 1220 +6 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
May 26, 2024
There was a problem hiding this comment.
I agree, nightly seems too noisy. An alternative we could consider would be to test against the latest tagged version by running one test with
version: '1'
include-all-prereleases: true(see https://github.com/julia-actions/setup-julia?tab=readme-ov-file#prereleases).
* Increase sample size when testing empirical moments of DiscreteNonParametric * Use StableRNGs for semicircle.jl to avoid breakage on 1.11-beta * Run CI on all PRs. Also CI for workflow_dispatch and merge_group * Update semicircle.jl Co-authored-by: David Widmann <devmotion@users.noreply.github.com> * Update locationscale.jl Co-authored-by: David Widmann <devmotion@users.noreply.github.com> * Update locationscale.jl Co-authored-by: David Widmann <devmotion@users.noreply.github.com> --------- Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
devmotion
reviewed
Aug 17, 2024
| @@ -34,6 +34,7 @@ jobs: | |||
| - uses: julia-actions/setup-julia@v2 | |||
| with: | |||
| version: ${{ matrix.version }} | |||
| include-all-prereleases: true | |||
There was a problem hiding this comment.
It seems this implies that currently only the prerelease is tested but no stable release anymore...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are so many failures that it makes the CI status useless. We should trigger CI upcoming Julia releases in dedicated PRs instead of unconditionally testing on nightly.