Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad default for multivariate normal #657

Open
andreasnoack opened this issue Aug 21, 2017 · 3 comments
Open

Bad default for multivariate normal #657

andreasnoack opened this issue Aug 21, 2017 · 3 comments

Comments

@andreasnoack
Copy link
Member

julia> D = MvNormal(zeros(2))
ZeroMeanDiagNormal(
dim: 2
μ: [0.0, 0.0]
Σ: [0.0 0.0; 0.0 0.0]
)
@simonbyrne
Copy link
Member

Yes, let's deprecate MvNormal(::AbstractVector) and replace it with MvNormal(::Diagonal)

@andreasnoack
Copy link
Member Author

Oh. It didn't even cross my mind that it would be the variance. I assumed that a vector would be the mean. So yes, let's definitely deprecate that for a Diagonal version. Eventually, I think we could consider reintroducing the constructor where the vector specifies the mean.

@simonbyrne
Copy link
Member

Actually, even more confusingly, it's standard deviation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants