Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't copy regex match strings #15

Merged
merged 4 commits into from
Feb 10, 2023
Merged

don't copy regex match strings #15

merged 4 commits into from
Feb 10, 2023

Conversation

stevengj
Copy link
Member

@stevengj stevengj commented Feb 9, 2023

Closes #14

@stevengj
Copy link
Member Author

stevengj commented Feb 9, 2023

Requires Julia 1.6 for JuliaLang/julia#38108 … probably not worth it nowadays to worry about backporting this.

@codecov-commenter
Copy link

Codecov Report

Merging #15 (04f6bee) into main (7c7f0b6) will decrease coverage by 5.85%.
The diff coverage is 20.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   75.05%   69.21%   -5.85%     
==========================================
  Files           6        6              
  Lines         417      458      +41     
==========================================
+ Hits          313      317       +4     
- Misses        104      141      +37     
Flag Coverage Δ
unittests 69.21% <20.00%> (-5.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/search.jl 44.15% <0.00%> (-5.12%) ⬇️
src/regex.jl 62.00% <17.14%> (-24.77%) ⬇️
src/StringViews.jl 96.87% <66.66%> (+0.04%) ⬆️
src/decoding.jl 86.36% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stevengj stevengj merged commit 9fe32cc into main Feb 10, 2023
@stevengj stevengj deleted the SVRegexMatch branch February 10, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eachmatch is copying the match strings
2 participants