Add Cox #8
Merged
Add Cox #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to indicate if a variable is a factor (categorical variable) automatically? |
|
Hum... I do not know, I will investigate. |
lrnv
reviewed
Jun 14, 2024
lrnv
reviewed
Jul 2, 2024
There was a problem hiding this comment.
We should someday move to Optimization.jl to export as a user-tunable parameter the algorithm used to solve the numerical problem. In Cox, that would imply providing fast implementation (compliant with Optimization.jl's standard) of the nllh, but also of its gradient and eventually the hessian.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Cox