Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for julia 1.0-1.3? #216

Closed
lgoettgens opened this issue Oct 17, 2023 · 4 comments · Fixed by #221
Closed

Drop support for julia 1.0-1.3? #216

lgoettgens opened this issue Oct 17, 2023 · 4 comments · Fixed by #221
Labels
question Further information is requested
Milestone

Comments

@lgoettgens
Copy link
Collaborator

#214 and thus #215 needed a workaround to circumvent an old problem in Pkg.jl in connection with Test.jl.
This would furthermore enable us to merge #195 eventually, thus removing a large code duplication with julia base.

or we just drop support for older Julia versions in Aqua.jl ? I am not sure how valuable it is? After all, as was pointed out, people on older Aqua versions can still use the old Aqua releases. If they want any new features, well, they have to upgrade Julia.
There may be some people who absolutely must stick on Julia 1.0, but that's seems like a rather fringe demographic?
-by @fingolfin on slack

I, personally, am in favor of this change. If somebody has some good reason why we should not proceed, please let me know.

@lgoettgens lgoettgens added the question Further information is requested label Oct 17, 2023
@lgoettgens lgoettgens added this to the 0.8 milestone Oct 17, 2023
@hyrodium
Copy link
Contributor

I think we can also drop versions before v1.6 if we drop support for v1.0 because the other versions such as v1.4 are not LTS.

@fingolfin
Copy link
Member

Also fine by me.

As it is, I wonder if it's worth bending over backwards if we don't even know whether anyone uses it...

One could of course also do something like this: the next release prints a notice when loaded in Julia <= 1.3 (or 1.5) saying something like "if you'd like to receive updates for Aqua.jl in Julia $(VERSION) then please let us know at ISSUEURL". Then we wait a bit and see if someone reacts.

@lgoettgens
Copy link
Collaborator Author

One could of course also do something like this: the next release prints a notice when loaded in Julia <= 1.3 (or 1.5) saying something like "if you'd like to receive updates for Aqua.jl in Julia $(VERSION) then please let us know at ISSUEURL". Then we wait a bit and see if someone reacts.

I don't know if many users look at ci logs when they succeed. And making the go red would be a breaking change. So no idea how to really do that

@hyrodium
Copy link
Contributor

It would be nice if Package downloads stats for Julia shows stats of the user's Julia version not just the total downloads...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants