Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare exported names with Compat.jl #5

Open
tkf opened this issue Dec 26, 2019 · 4 comments
Open

Compare exported names with Compat.jl #5

tkf opened this issue Dec 26, 2019 · 4 comments
Labels
enhancement New feature or request new test

Comments

@tkf
Copy link
Member

tkf commented Dec 26, 2019

as in JuliaData/DataFrames.jl#2067 / https://github.com/JuliaData/DataFrames.jl/blob/adc634adf4d2d41ca041486348fbc27de7d0ad31/test/compat.jl

@fingolfin
Copy link
Collaborator

After a quick look at the provided links, I am not sure what you have in mind here?

Without knowing what this is about, we can't resolve this issue...

@lgoettgens
Copy link
Collaborator

I think this is a proposal to add a new test category to Aqua.

The Compat.jl package tries to bring features of newer julia versions to older ones by providing it in that package (instead of Base). If some package uses Compat.jl, the referenced issue recommends to import functions from Compat and adding new dispatches to them instead of defining new functions (and thus shadowing the ones from Compat).

@fingolfin
Copy link
Collaborator

But what would the test do? Check whether the module being tested exports (or just defines?) any symbols :foo that is also exported by Compat, and if so, check whether Compat.foo === MyPackage.foo?

@lgoettgens
Copy link
Collaborator

But what would the test do? Check whether the module being tested exports (or just defines?) any symbols :foo that is also exported by Compat, and if so, check whether Compat.foo === MyPackage.foo?

That is exactly what https://github.com/JuliaData/DataFrames.jl/blob/adc634adf4d2d41ca041486348fbc27de7d0ad31/test/compat.jl does.

@lgoettgens lgoettgens added enhancement New feature or request new test labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new test
Projects
None yet
Development

No branches or pull requests

3 participants