From 96238a535777f495c1481832de2414f2a6eb9ff6 Mon Sep 17 00:00:00 2001 From: Jishnu Bhattacharya Date: Sun, 7 Apr 2024 23:47:03 +0530 Subject: [PATCH 1/2] Fix failing persistent task example in doc --- docs/Project.toml | 1 + docs/src/persistent_tasks.md | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/Project.toml b/docs/Project.toml index 842889d9..ceff907e 100644 --- a/docs/Project.toml +++ b/docs/Project.toml @@ -1,4 +1,5 @@ [deps] +Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" Changelog = "5217a498-cd5d-4ec6-b8c2-9b85a09b6e3e" Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" diff --git a/docs/src/persistent_tasks.md b/docs/src/persistent_tasks.md index 49371c19..bb09aff6 100644 --- a/docs/src/persistent_tasks.md +++ b/docs/src/persistent_tasks.md @@ -48,9 +48,10 @@ end) Here is an example test with a dummy expr which will obviously fail, because it's explicitly spawning a Task that never dies. ```@repl -Aqua.test_persistent_tasks(Aqua, quote +import Aqua +Aqua.test_persistent_tasks(Aqua, expr = quote Threads.@spawn while true sleep(0.5) end -end +end) ``` ## How the test works From 6ef093fba102e9bd8e2f1fc110b4a9d9618020e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Mon, 8 Apr 2024 17:00:07 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- docs/Project.toml | 1 - docs/src/persistent_tasks.md | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/Project.toml b/docs/Project.toml index ceff907e..842889d9 100644 --- a/docs/Project.toml +++ b/docs/Project.toml @@ -1,5 +1,4 @@ [deps] -Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" Changelog = "5217a498-cd5d-4ec6-b8c2-9b85a09b6e3e" Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4" diff --git a/docs/src/persistent_tasks.md b/docs/src/persistent_tasks.md index bb09aff6..cd3e6f85 100644 --- a/docs/src/persistent_tasks.md +++ b/docs/src/persistent_tasks.md @@ -48,7 +48,7 @@ end) Here is an example test with a dummy expr which will obviously fail, because it's explicitly spawning a Task that never dies. ```@repl -import Aqua +using Aqua Aqua.test_persistent_tasks(Aqua, expr = quote Threads.@spawn while true sleep(0.5) end end)