Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in printing on 1.3 causes tests to fail #216

Closed
KristofferC opened this issue Sep 20, 2019 · 1 comment · Fixed by #217
Closed

Changes in printing on 1.3 causes tests to fail #216

KristofferC opened this issue Sep 20, 2019 · 1 comment · Fixed by #217

Comments

@KristofferC
Copy link
Contributor

Tests fail on upcoming 1.3 with

TimeZones: Test Failed at /root/.julia/packages/TimeZones/UXytc/test/utcoffset.jl:51
  Expression: sprint(show, UTCOffset(0, 0)) == "UTCOffset(Second(0), Second(0))"
   Evaluated: "UTCOffset(0 seconds, 0 seconds)" == "UTCOffset(Second(0), Second(0))"

Make some noise if this is a bad thing :)

@omus
Copy link
Member

omus commented Sep 24, 2019

Thanks. I didn't expect this to get reverted in 1.3 but since it was already reverted as part of 1.3-rc1 and 1.3-rc2. As long as it doesn't get reverted in master and it finally makes it into 1.4 I'm happy.

JuliaLang/julia#33178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants