Give a better error message if token contains newlines #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keno
force-pushed
the
kf/authtokenerror
branch
2 times, most recently
from
7d5947f
to
cee2dbb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 57.76% 58.13% +0.37%
==========================================
Files 37 37
Lines 902 910 +8
==========================================
+ Hits 521 529 +8
Misses 381 381 ☔ View full report in Codecov by Sentry. |
KristofferC
reviewed
Nov 24, 2023
| @@ -21,3 +21,5 @@ auth2 = GitHub.JWTAuth(1234, key; iat = DateTime("2016-9-15T14:00")) | |||
| # test to make sure things don't break. | |||
| @test auth.JWT == correct_jwt | |||
| @test auth2.JWT == correct_jwt | |||
|
|
|||
| @test_throws ArgumentError GitHub.OAuth2("ghp_\n") | |||
There was a problem hiding this comment.
In theory would be good to test the JWTAuth constructor as well.
KristofferC
approved these changes
Nov 24, 2023
I constructed a token as `OAuth2(read("token", String))`, but my
token file had a trailing newline. GitHub stops parsing headers
after an empty line, so depending on where the header ended up
in the list of headers, this was causing all sorts of strange errors.
Detect this situation and throw an intelligent error in GitHub.jl instead.
Keno
force-pushed
the
kf/authtokenerror
branch
from
cee2dbb
to
fff5213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I constructed a token as
OAuth2(read("token", String)), but my token file had a trailing newline. GitHub stops parsing headers after an empty line, so depending on where the header ended up in the list of headers, this was causing all sorts of strange errors. Detect this situation and throw an intelligent error in GitHub.jl instead.