Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default timeouts are incorrectly documented (and maybe dangerous per #114) #123

Closed
samoconnor opened this issue Nov 20, 2017 · 2 comments
Closed

Comments

@samoconnor
Copy link
Contributor

In client.jl and types.jl the default connect and read timeouts are specified as 10 s and 9 s.

The code currently uses 15 seconds as the default:

const DEFAULT_OPTIONS = :((nothing, true, 15.0, 15.0, nothing, 5, true, false, 3, true, true, false, true, true))

Perhaps in the light of #114 it would be better for the default timeout to be Inf (which would result in the usual timeouts of the underlying TCP connection taking effect).

@quinnj quinnj closed this as completed Nov 26, 2017
@xgdgsc
Copy link

xgdgsc commented May 12, 2020

What's the default timeout for now? Didin' t find in doc or code myself. Is it 0?

@quinnj
Copy link
Member

quinnj commented May 27, 2020

function request(::Type{TimeoutLayer{Next}}, io::IO, req, body;
                 readtimeout::Int=60, kw...) where Next

so 60 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants