Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collecting all errors, and see #5

Closed
reslear opened this issue Sep 29, 2022 · 5 comments
Closed

collecting all errors, and see #5

reslear opened this issue Sep 29, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@reslear
Copy link
Contributor

reslear commented Sep 29, 2022

hi @Julien-R44 i'm suggest, collect all errors and display before exit all missing variables.

My case, the build takes 10 minutes, the plugin reports about missing variable. We add a variable, run the build again, again 10 minutes, and so on...

similar feature released in znv for backend.

image

@Julien-R44
Copy link
Owner

Hey dude!
It's a good idea, you're right, thanks. I will try to do it this weekend

However: which build are you talking about? A docker image, or something else?

Because normally if you are missing an environment variable, the plugin is supposed to warn you before building anything, just after typing vite build

@Julien-R44 Julien-R44 self-assigned this Sep 29, 2022
@Julien-R44 Julien-R44 added the enhancement New feature or request label Sep 29, 2022
@Julien-R44
Copy link
Owner

Btw, thanks for sharing znv. There are a lot of good ideas in there. I'll steal some of them 😋

@reslear
Copy link
Contributor Author

reslear commented Sep 29, 2022

Hey dude! It's a good idea, you're right, thanks. I will try to do it this weekend

However: which build are you talking about? A docker image, or something else?

Because normally if you are missing an environment variable, the plugin is supposed to warn you before building anything, just after typing vite build

yes, is vite build in docker container on gitlab ci/cd with ionic appflow for mobile deploy

@Julien-R44
Copy link
Owner

Here is the new output :

image

@reslear
Copy link
Contributor Author

reslear commented Oct 1, 2022

stylish and sensible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants