Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MIDI Input buffer size in Windows #15

Closed
lozjackson opened this issue Apr 3, 2024 · 3 comments · Fixed by #18
Closed

Set MIDI Input buffer size in Windows #15

lozjackson opened this issue Apr 3, 2024 · 3 comments · Fixed by #18

Comments

@lozjackson
Copy link

We would like to use this library, however we have a specific requirement to be able to send large MIDI message packets up to 16384 bytes in size.

I can see there is an option to set the buffer size in RT MIDI here: https://github.com/thestk/rtmidi/blob/master/RtMidi.cpp#L864

The buffer size is currently limited to 2048 here: https://github.com/Julusian/node-midi/blob/master/src/input.cpp#L48

Is there any easy way to override that from our app when consuming node-midi?.. if thats not currently possible would you be willing to add an option to configure it?

@lozjackson lozjackson changed the title Set MIDI In buffer size in Windows Set MIDI Input buffer size in Windows Apr 10, 2024
@lozjackson
Copy link
Author

@Julusian any chance of looking into this? it would really help us out.

@lozjackson
Copy link
Author

@Julusian I've opened a PR to implement the setBufferSize() method. Hoping you'd be willing to merge and release this

@Julusian
Copy link
Owner

Julusian commented May 9, 2024

Thanks, this is published in v3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants