Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases with spaces don't work #2413

Closed
3 tasks done
Jonas1999 opened this issue Jun 12, 2024 · 2 comments
Closed
3 tasks done

aliases with spaces don't work #2413

Jonas1999 opened this issue Jun 12, 2024 · 2 comments
Labels
s/on hold There is something blocking this issue s/planned We'll probably do this at some point t/q&a A question was asked and maybe answered

Comments

@Jonas1999
Copy link

What went wrong?

I'm trying to get "restart upgrade": ["upgrade", "update", "test"] in aliases.json to work but it doesn't work.
My other aliases work except that one, the entire aliases.json contains the following:
{ "play": ["p"], "skip": ["s"], "queue": ["q"], "latency": ["ping"], "restart": ["reboot", "reset"], "restart upgrade": ["upgrade", "update", "test"], "checkupdates": ["checkupdate"], "summon": ["join", "connect", "come"], "disconnect": ["leave", "stop"] }

How do we reproduce this?

Have an aliases.json contain what I mentioned above and run the bot, the aliases won't be acknowledged by the bot.
The bot is running on an Raspberry Pi 4 with Debian 12/ Raspberry Pi OS 64 Bit.

Which version of the bot are you using?

I am using the "review" branch

Which operating system are you using?

Ubuntu 18.04 or higher

Just checking...

  • I have confirmed that my issue has not already been reported.
  • I am using Python 3.8 or higher.
  • I have updated my Python dependencies.
@Jonas1999 Jonas1999 added needs triage t/bug This issue is quite clearly a bug labels Jun 12, 2024
@itsTheFae
Copy link
Contributor

Currently, aliases are quite limited and will only function as replacement names for command names.

I did poke around with this while working on the last few rounds of updates. I think the feature could definitely use a handful of changes. For example, being able to manage the aliases via command would be nice to have, or minimally some indicator that the aliases even exist via like help command responses.

At least I can say it was on my radar. Was going to take it on before doing the UI stuff I had planned. But it could be a while before I get the time to work out proper updates for it.

@BabyBoySnow BabyBoySnow added t/q&a A question was asked and maybe answered s/planned We'll probably do this at some point s/on hold There is something blocking this issue and removed t/bug This issue is quite clearly a bug needs triage labels Jun 12, 2024
@Just-Some-Bots Just-Some-Bots locked and limited conversation to collaborators Jun 12, 2024
@BabyBoySnow
Copy link
Collaborator

I'm closing this as complete due to the latest pr merged into dev, if it still doesn't meet you're requirements feel free to open a new issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
s/on hold There is something blocking this issue s/planned We'll probably do this at some point t/q&a A question was asked and maybe answered
Projects
None yet
Development

No branches or pull requests

3 participants