-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contributors are welcome! #18
Comments
Hi @uriklar , I am working on another fork of react-google-maps, but since you guys already started this one, i would like to contribute instead of perusing my own fork. I am working on project which uses react-google-maps, and i faced some issues for which i had to override some behaviors in some of the components.
Please let me know If that is something you would like to incorporate into this fork? Then i can start working on preparing PR. Plus one more thing this lib doesn't build on windows machine, and i have to add few things to package.json make is work. |
Hi @xalisys, we'd be happy to add you code. I saw your fork, but didn't see the commits you mentioned. Can you send me a link? And a PR to fix the windows build would be greatly appreciated! |
@uriklar thanks for quick response, the code i mentioned is in my project where i override the react-google-maps, components. I'll create separate PRs for things aforementioned. thanks. |
Hi @uriklar |
Hi @gregoryfm! Send me the email of your slack account and i'll send you an invite. (You can also mail me at uriklar@gmail.com if you prefer) |
I sent you an email |
As I already mentioned somewhere else ... I would like to contribute, however seeing this project is almost dead already, I don't feel like it's worth the time. Did everyone get so busy suddenly to let this die? |
Hi @FredyC, Why do you say it's dead? As Alexey mentioned in several places, we use this lib for our personal and company's projects, so our work on it is focused on those needs. But we will gladly help anyone who wants to contribute and will surely put in some more work in when we have the time for it. |
I totally understand it's not like the main project you want to invest too much time into. In that case, it might been better to just keep it private instead of saying everywhere that this is a replacement lib. How it can be when it's lacking features that Do you even adhere to semver? With your "hobby" approach I feel like the stability could be rather volatile. There are no tests which I would say is kinda a must for a library. Otherwise, it's just a code that was mangled together to make some basic scenarios working (with fingers crossed). Documentation is rather sparse and it's hard to tell what's actually working and what isn't. I do appreciate your valiant effort for sure, but at this point, I feel like I would just fork |
First of all, for the best of my knowledge react-google-maps doesn't have any tests either. I know that some components are missing, but, did you look at the code? It's so easy to just pick a component up and implement it! For documentation we use docz which makes adding docs even easier. I agree with you this project deserves more work then it gets.. If react-google-maps works for you, I don't see any reason to migrate. For me, the main use case for migrating from would have to be Async React readiness (which @react-google-maps/api is), also reduced bundle size is a nice touch. |
Fair enough, there are a few basic tests, but probably not that useful.
I did not. Honestly, seeing JS code base just gives me shivers as it means that touching anything can break stuff fairly easily (especially with no tests). Unless the decision for TypeScript happens, I don't think I will be able to contribute.
It works, but there are some quicks for sure that could be solved here better. For starters we have fully embraced React Hooks, so seeing class-based context is just bad :) |
We haven't used hooks in this project as they haven't been released yet. Once they're released this whole lib might as well be shrunk into a single hook :-) If you feel like making a PR to kick off the Typescript migration effort I will gladly join in on that branch! |
@FredyC We have done refactor to typescript, if you have time can you please review? |
@JustFly1984 It's definitely on my todo list. Lately, more and more issues are coming from the abandoned maps project, so there is a hoping it will improve with this one. |
@FredyC We have published @1.2.0 with full typescript support. |
Thank you for all the hard work. Tried to integrate into a project today and it was surprisingly easy to migrate. Not that it's some heavy map usage app, mostly just a couple of I got a few pointers.
I might work on PRs tomorrow if desired. |
Hi @FredyC, While you're here :-) I actually have a Typescript question that maybe you'll know the answer to: I'm using other libraries with direct (that is, not via DefinitelyTyped) TS support (for example styled-component) and they didn't require me to change the module resolution. Changing it makes my initial build suuuuper slower. Got any ideas on that? I'm wondering if our tsconfig setup is correct... Should we be using rollup? I see you're using it on mobx-react-lite. Thanks again! |
I need access to the Regarding your typescript problem I am not sure really, but I am using
Well, you definitely have a fairly robust config, I usually get away with defaults and tweak some basics. I don't know half of that stuff what is it doing actually :) Might be worth investigating if you need all that.
I used it because I know it, but I heard lately good opinions about |
@FredyC Thank you for improvements, I will publish new version tomorrow |
@FredyC Please add yourself to contributors list in /package/react-google-maps-api/package.json |
@FredyC can you please provide an example of useGoogleMap hook for docs and for gatsby-example? |
There is no list in that file :) Doesn't matter, it would be too hidden anyway, so I don't care.
Ok, hopefully by tomorrow I will able to stitch something together. |
Hello! We have started using this library for the implementation at my workplace (well, mostly me). As I understand it from perusing the issues, it looks like it's the case for most contributors. I don't know yet if I will have the ability to contribute anything meaningful (still pretty junior), but I certainly would like to try. And I am wondering if it would be desirable, on top of the private Slack channel, to maintain a Slack / Spectrum / Gitter channel for questions regarding specific use cases. I personally have a few, but as their place is probably not in the |
I would kinda vote for Spectrum as well. Personally, I already have too many Slacks and want to limit that. Spectrum at least does not force to you have a separate set of credentials for each community. Although I don't exactly adore that platform just yet, it's still under heavy development and sometimes wonky. But it's a good alternative. The Gitter is useful for quick chatting too, but no separation per topic makes it useless for QA. |
Hi @mathieu-anderson. Here's a link to our newly created community: https://spectrum.chat/react-google-maps Maybe your first PR could be adding it to the docs? :-) |
Lightning fast reaction time @uriklar ! I posted the first question on Spectrum! And yes, I might look at adding to the docs! What's the process to make PRs to the project? |
HI @uriklar |
Hi @shobishani, |
@uriklar Thanks.. sure will submit PR |
Is anybody working on the implementation of |
@JustFly1984 @uriklar Hey, do you know that latest 1.2.3 build is actually broken? In package.json you are referring to UMD folder, but it's not included in the build. Perhaps you haven't intended to release it yet and it should have been another alpha? https://unpkg.com/@react-google-maps/api@1.2.3/ I would highly recommend not to use |
@FredyC Thank you! |
@JustFly1984 @uriklar I'd like to take a crack at the OverlayView performance issues. But I don't have experience with Maybe add me to slack so I can talk with you there? I'll send an email to @uriklar |
Hi @joaoreynolds. Right now, the top issue preventing people from contributing is the lack of a good workflow for working on the library. Let me know if maybe you want to start from that. I'd be happy to assist on slack |
I tried using npm link between Thoughts? |
The problem is that storybook does not support typescript. You can’t import TD files from storybook. The solution will be to create separate package react-google-maps-api-cra-example with typescript enabled. This way we could import TD files Another way is to add typescript to react-google-maps-api-gatsby-example |
Ahh gotcha - okay I can create the cra example. I'll keep you updated if I have more questions. |
Does ImageMapType supported? |
Hi, |
@rbonigala we have only gatsby-example in the repo, but in general SSR with next js should not be different than static rendering with Gatsby. Inshort - you can't render it in SSR, cos it requires DOM and injecting script tag in runtime. for SSR you can render fallback instead. |
I find this very thru! I would like to give it a try. If someone can help with any working workflow, no matter how terrible it is, it would be great. I feel like How to test changes locally is outdated). So far I have noticed the following issues, that might need new issues created:
|
Hello guys. Maybe you know why documentation is down? https://react-google-maps-api-docs.netlify.app/ Maybe you could fix it, please :) |
Is anyone making documentation site up ? |
@vijay-t13 it is open source. If you want you can fix it. I will merge it and deploy. By now the config for docs is not updated to support latest current version, so docs build is broke. Somebody did a PR with downgrading docs to old version, and it is possible to run, but downgrading is not a good option. docs should be configured according new major version. |
Heads up, guys When i run [commonjs--resolver] Failed to resolve entry for package "/var/www/Project/node_modules/@react-google-maps/api". The package may have incorrect main/module/exports specified in its package.json. After I revert my version to previous in |
@iuliiaostapenko Do you want to became a contributor? |
@iuliiaostapenko since now, accepting issues only with PR to fix it. There is no guys, I'm here alone maintaining this project. |
Hi everyone,
We'd love to get your code contributions! We have a slack channel that is currently on an invite basis. Leave a note here if you want to join.
There are some components that need to be revised from their old (react-google-maps) implementation, to our new implementation. For an examples of such a conversion, see this commit
Here are the components that still need to be implemented
Other open tasks:
mdx
files in the docs folder. We want to achieve coverage for all components in the docsThe text was updated successfully, but these errors were encountered: