Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting empty tensors to array #180

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Fix converting empty tensors to array #180

merged 10 commits into from
Nov 21, 2024

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Nov 20, 2024

This PR fixes #178

test/tensors.jl Outdated Show resolved Hide resolved
@Jutho
Copy link
Owner

Jutho commented Nov 20, 2024

It would be great if you could also add Base.zero(V::ElementarySpace) on line 92 of "docs/src/lib/spaces.md". (If current CI has already finished, this can be with [skip ci]; the docs will be built when this is merged.)

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (f467a21) to head (d594dec).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/spaces/generalspace.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   81.39%   82.80%   +1.41%     
==========================================
  Files          42       42              
  Lines        5218     5212       -6     
==========================================
+ Hits         4247     4316      +69     
+ Misses        971      896      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lkdvos lkdvos merged commit f7eabe5 into master Nov 21, 2024
13 of 14 checks passed
@lkdvos lkdvos deleted the ld-emptytensor branch November 21, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert to Array fails for empty TensorMap
2 participants