Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix Maven artifacts with kable- #692

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jun 12, 2024

We've seen issues for library consumers that manifest in various ways when multiple libraries have the same Maven artifact name.

Most recently, with the K2 upgrade, on the consumer side, we saw failures similar to:

e: KLIB resolver: Could not find "com.juul.tuulbox:encoding" in [/Users/ci/Library/Application Support/kotlin/daemon]

This occurred because our internal project had an encoding module which clashed with Tuulbox's and another of our internal libraries artifacts named encoding.

We resolved it by renaming our internal library's Maven artifact to be prefixed.

Additionally, it seems to be standard for libraries to prefix their Maven artifact names, for example: kotlinx-coroutines-core

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Jun 12, 2024
@twyatt twyatt added this to the 0.33.0 milestone Jun 12, 2024
@twyatt twyatt marked this pull request as ready for review June 12, 2024 22:44
@twyatt twyatt requested a review from a team as a code owner June 12, 2024 22:44
@twyatt twyatt merged commit a57b051 into main Jun 13, 2024
3 checks passed
@twyatt twyatt deleted the twyatt/maven-artifact-names branch June 13, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants