Make isSupported always true on Apple
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
force-pushed
the
twyatt/bluetooth-is-supported
branch
from
d1aa4c8
to
e7eb499
Compare
sdonn3
approved these changes
Sep 18, 2024
davidtaylor-juul
approved these changes
Sep 19, 2024
twyatt
force-pushed
the
twyatt/bluetooth-is-supported
branch
from
e7eb499
to
7a69d5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously found Determine whether bluetooth is enabled on iOS (passively), and even tested it!
Although, I mistakenly thought
CBCentralManagerOptionShowPowerAlertKeyhad suppressed all dialogs, only to later realize I had already granted permission to the app, so it was only suppressing the "turn BLE on" dialog, as mentioned in What causes this iOS permission prompt for "use Bluetooth for new connections"?.Ultimately, it seems (as far as I can tell) there is no way to passively check if BLE is supported on Core Bluetooth. As a result, we have to blindly assume it is available for this API to have uniform behavior on all platforms.
I'm strongly considering removing
isSupportedfromcoreKable (perhaps providing it as a separate module instead). 🤷Alternatively/instead, could go with #753.