From ceeab84e7f6b019d9af248a8bef34d4de9fa22cb Mon Sep 17 00:00:00 2001 From: Travis Wyatt Date: Wed, 31 Aug 2022 12:09:24 -0700 Subject: [PATCH 1/2] Change code owners to `@JuulLabs/conx-kotlin-reviewers` (#210) --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index c755a769..6d3f5681 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,3 @@ # https://help.github.com/articles/about-codeowners/ -* @JuulLabs/conx-app-reviewers +* @JuulLabs/conx-kotlin-reviewers From 82f2ba1152d297a303ce205998a37bbf46fc5dac Mon Sep 17 00:00:00 2001 From: Travis Wyatt Date: Thu, 1 Sep 2022 10:42:38 -0700 Subject: [PATCH 2/2] Use Gradle type-safe project accessors (#209) --- logging-android/build.gradle.kts | 2 +- logging-ktor-client/build.gradle.kts | 6 +++--- logging-test/build.gradle.kts | 2 +- logging/build.gradle.kts | 2 +- settings.gradle.kts | 2 +- temporal/build.gradle.kts | 4 ++-- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/logging-android/build.gradle.kts b/logging-android/build.gradle.kts index 2a1e6055..d869d435 100644 --- a/logging-android/build.gradle.kts +++ b/logging-android/build.gradle.kts @@ -16,7 +16,7 @@ kotlin { sourceSets { val commonMain by getting { dependencies { - api(project(":logging")) + api(projects.logging) } } } diff --git a/logging-ktor-client/build.gradle.kts b/logging-ktor-client/build.gradle.kts index aeeeccd1..c7d636ab 100644 --- a/logging-ktor-client/build.gradle.kts +++ b/logging-ktor-client/build.gradle.kts @@ -24,7 +24,7 @@ kotlin { sourceSets { val commonMain by getting { dependencies { - api(project(":logging")) + api(projects.logging) api(libs.ktor.core) api(libs.ktor.logging) } @@ -32,8 +32,8 @@ kotlin { val commonTest by getting { dependencies { - implementation(project(":logging-test")) - implementation(project(":test")) + implementation(projects.loggingTest) + implementation(projects.test) implementation(kotlin("test-common")) implementation(kotlin("test-annotations-common")) implementation(libs.ktor.mock) diff --git a/logging-test/build.gradle.kts b/logging-test/build.gradle.kts index 43206a1c..4a821b65 100644 --- a/logging-test/build.gradle.kts +++ b/logging-test/build.gradle.kts @@ -19,7 +19,7 @@ kotlin { sourceSets { val commonMain by getting { dependencies { - api(project(":logging")) + api(projects.logging) } } } diff --git a/logging/build.gradle.kts b/logging/build.gradle.kts index ec2c07c6..b8d75225 100644 --- a/logging/build.gradle.kts +++ b/logging/build.gradle.kts @@ -26,7 +26,7 @@ kotlin { val commonTest by getting { dependencies { - implementation(project(":logging-test")) + implementation(projects.loggingTest) implementation(kotlin("test-common")) implementation(kotlin("test-annotations-common")) } diff --git a/settings.gradle.kts b/settings.gradle.kts index 2ebe0eff..5243ab5d 100644 --- a/settings.gradle.kts +++ b/settings.gradle.kts @@ -1,4 +1,4 @@ -enableFeaturePreview("VERSION_CATALOGS") +enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") pluginManagement { repositories { diff --git a/temporal/build.gradle.kts b/temporal/build.gradle.kts index 21b984ef..0c61af2e 100644 --- a/temporal/build.gradle.kts +++ b/temporal/build.gradle.kts @@ -40,7 +40,7 @@ kotlin { val commonTest by getting { dependencies { - implementation(project(":test")) + implementation(projects.test) implementation(kotlin("test-common")) implementation(kotlin("test-annotations-common")) implementation(libs.kotlinx.coroutines.test) @@ -49,7 +49,7 @@ kotlin { val androidMain by getting { dependencies { - implementation(project(":coroutines")) + implementation(projects.coroutines) } }