Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xmath - provide implementation or replace by glm #46

Open
SSE4 opened this issue Jun 9, 2021 · 2 comments
Open

xmath - provide implementation or replace by glm #46

SSE4 opened this issue Jun 9, 2021 · 2 comments

Comments

@SSE4
Copy link
Contributor

SSE4 commented Jun 9, 2021

there is xmath library which we don't currently have source for.
right now, it's available as pre-built Visual Studio 2005 library only.
it means, if we decide to port to another architecture (x64) or platform (Linux/Mac), we have to provide an implementation.

xmath provides:

  • vectors (Vect3f, Vect3d, etc.)
  • quaternions (QuatF)
  • matrices (Mat3f, Mat3d, etc)

and various functions to manipulate with them (invert, product, etc.)

there are currently two different xmath.h headers:
https://github.com/KranX/Perimeter/blob/init/Source/Util/xmath.h
https://github.com/KranX/Perimeter/blob/init/XLibs.Net/xmath.h

there is also umath.h header: https://github.com/KranX/Perimeter/blob/init/Source/Render/inc/Umath.h
which provides similar classes (vectors).

GLM project might be a good replacement for these classes, need to check if it has all functions needed.

@IonAgorria
Copy link
Collaborator

Small update, on cmake branch the two xmath.h were merged into one and moved to https://github.com/KranX/Perimeter/blob/cmake/Source/XTool/xmath.h which also has the original xmath.cpp

umath.h seems to be a graphics related superset of xmath.h, in future if we end up using another renderer it may be necessary to change these or scratch it... for example CMatrix has a casting operator to DirectX D3DXMATRIX

Might be worth reviewing if is worth moving to GLM now that we got xmath sources...

@DileSoft
Copy link
Member

Yes, I think it will be good to replace these functions to standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants