Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKAN Mod install larger than 100% #2508

Closed
zwang20 opened this issue Aug 21, 2018 · 3 comments · Fixed by #2539
Closed

CKAN Mod install larger than 100% #2508

zwang20 opened this issue Aug 21, 2018 · 3 comments · Fixed by #2539
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN

Comments

@zwang20
Copy link

zwang20 commented Aug 21, 2018

Background

CKAN Version:
v1.25.2+2321d887ba46

KSP Version:
1.4.5.2243

Operating System:
Mac OSX High Sierra
10.13.4 (17E199)

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?
Yes, but I have removed all the mods as stated in the documentation and installed them via CKAN

Problem

What steps did you take in CKAN?
use the terminal command CKAN prompt
install SmartTank
(this also happened with other mods)

What did you expect to happen?
The downloading process would stop at 100%

What happened instead?

The downloading progress ticks over 100%
This isn't really a huge problem, but its just annoying to watch
After it finishes it resets to 100%

Screenshots:

screen shot 2018-08-21 at 8 56 34 pm

@HebaruSan HebaruSan added Network Issues affecting internet connections of CKAN Core (ckan.dll) Issues affecting the core part of CKAN labels Aug 21, 2018
@HebaruSan
Copy link
Member

I think this has to do with the archive.org fallback URLs. If GitHub lets you download part of a file and then throttles your download, CKAN starts downloading the archive.org file without resetting the download byte count, so the total number of bytes downloaded is more than the size of the file.

@HebaruSan HebaruSan added the Bug Something is not working as intended label Aug 21, 2018
@HebaruSan
Copy link
Member

Looked into this a little more. CKAN doesn't track the download byte count independently; it always comes from WebClient events, both before and after we start the fallback URL. So we'd either have to tell WebClient to change its byte counts somehow, or tweak how we get that info from it.

@LastStarDust
Copy link

I am experiencing the very same problem in Ubuntu 18.04 as shown in this picture
OS: Ubuntu 18.04 x86_64
CKAN: 1.25.3
KSP: 1.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants