-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] ValueError: SHA could not be resolved, git returned: b'' #89
Comments
https://gitpython.readthedocs.io/en/stable/reference.html Never mind, it's there: https://gitpython.readthedocs.io/en/stable/reference.html#git.repo.base.Repo.head And it looks like the rest of the properties should still work as well: https://gitpython.readthedocs.io/en/stable/reference.html#git.refs.head.Head |
Found same stack trace in gitpython-developers/GitPython#1121 / gitpython-developers/GitPython#1180 ... which unfortunately concluded without identifying a cause or solution, and instead kind of petered out with something resembling a workaround or the start of an investigation. |
Link for easy auditing of the code that throws: https://github.com/gitpython-developers/GitPython/blob/main/git/cmd.py |
gitpython-developers/GitPython#1016 looks also related and possibly more enlightening:
This suggests a two-part problem; first, |
Since that hypothesis implicates permissions, here's where our workflows are configured:
So far I see no indication that we're doing anything weird, but who knows what might be going on all these GitHub Actions... |
It says the default is true, so it seems like that should already be in effect, but maybe we need to use a newer version? EDIT: Yup. That's for v3, and we're using v2! EDIT 2: Nope, v2 was already running the safe directory command. Maybe they did a hotfix. |
Ohhhhh. actions/checkout#762:
All they were fixing was the checkout action itself failing. Downstream users may still be affected. |
When I set up HOME env to my user home directory the error disappear: |
#90 seems to have fixed this, based on KSP-CKAN/NetKAN#9513's validation now having succeeded. |
Might I suggest that you set up a backup of the validator image so that if it ever breaks again, you can revert to the previous version? |
Problem
The metadata tester is broken. It now emits this every time it runs:
It worked on this commit:
And broke on this one, one minute later:
In between, the docker image was regenerated:
... as a result of this commit:
KSP-CKAN/CKAN@d011444
So presumably something in the dependencies changed. There was a GitPython release 3 weeks ago, but reading the main issue it fixed didn't reveal much to me:
<gitpython::clone> 'ext::sh -c touch% /tmp/pwned'
for remote code execution gitpython-developers/GitPython#1515If there's a connection between that and
repo.head.commit.hexsha
no longer working, it eludes me.The text was updated successfully, but these errors were encountered: