Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Add GHA to run snforge test for contracts #98

Open
danielcdz opened this issue Jan 21, 2025 · 8 comments · May be fixed by #114
Open

[FEAT]: Add GHA to run snforge test for contracts #98

danielcdz opened this issue Jan 21, 2025 · 8 comments · May be fixed by #114
Assignees
Labels
difficult: medium enhancement New feature or request ODBoost This issue will be available ONLY during the ODBoost

Comments

@danielcdz
Copy link
Member

danielcdz commented Jan 21, 2025

📘 Description

To maintain the quality and stability of our contracts, we need a GitHub Action (GHA) that runs snforge test to verify that all contract tests pass successfully. This action will act as a safeguard to ensure new changes in pull requests (PRs) do not introduce any test failures or regressions.

✅ Acceptance Criteria

  • A GitHub Action is created and integrated to run snforge test on all contracts.
  • The action is triggered automatically for every new PR.
  • The action provides clear feedback on whether the tests passed or failed, with detailed logs available for debugging if failures occur.

🌎 References

📜 Additional Notes

  • Do not apply until the ODBoost begins.
  • Read our contribution guidelines before applying.
@danielcdz danielcdz added difficult: medium enhancement New feature or request ODBoost This issue will be available ONLY during the ODBoost labels Jan 21, 2025
@Birdmannn
Copy link

Please can I work on this task? I will use the references as stated. I will keep in touch in the tg gc

@beeguy74
Copy link

Hi, I am a beginner Cairo developer from Paris.
Closed 3 tasks totally on cairo during previos ODHACKs.
I never worked with GH actions, but it seems like an interesting tasks for me and i am going to crack it =)
I will do the draft PR within 24 hours.
Could I try solving this?

@emarc99
Copy link
Contributor

emarc99 commented Jan 22, 2025

I have implemented github workflow for python code coverage (pycoverage) on Spotnet during an OD hack. And I just graduated Cum Laude from BaseCamp 11.
I can do this with ETA - 1 day max.

@raizo07
Copy link

raizo07 commented Jan 22, 2025

Hello, can I be assigned to work on this?

Along side the run scarb build, I can also set this up.

I'm a Software developer with over four years of experience and over 60 contributions on OnlyDust.

ETA: 10 hours

@Jagadeeshftw
Copy link

Proposal to Work on the Issue

I would be delighted to contribute to this issue, as I have extensive experience with Cairo programming and developing decentralized applications on StarkNet.

Estimated Timeline

I anticipate delivering a working solution within the next 24 hours. Please let me know if I can proceed.

Looking forward to contributing and collaborating!

Best regards,
Jagadeesh B

@pheobeayo
Copy link

May I take care of this?

@ShantelPeters
Copy link
Contributor

Can I take this issue?

@Wendyalbert
Copy link

May I try my hand at this?

@raizo07 raizo07 linked a pull request Jan 23, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficult: medium enhancement New feature or request ODBoost This issue will be available ONLY during the ODBoost
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants