Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid can't build #116

Closed
licaon-kter opened this issue Mar 7, 2024 · 9 comments
Closed

F-Droid can't build #116

licaon-kter opened this issue Mar 7, 2024 · 9 comments

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Mar 7, 2024

I've updated to Java17 but: https://gitlab.com/fdroid/fdroiddata/-/jobs/6342586293#L391

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/5909cb0bdb3a5211f4f31d16e3e0a7385d1116df

@Kaljurand
Copy link
Owner

Hopefully fixed by just removing the dependency on BuildConfig.

@licaon-kter
Copy link
Contributor Author

licaon-kter commented Mar 11, 2024

Now it's a different error: ee.ioc.phon.android.speak_1916.log.gz

/LE: see below

@Kaljurand Kaljurand reopened this Mar 12, 2024
@Kaljurand
Copy link
Owner

The ee.ioc.phon.android.speak_1916.log.gz URL does not resolve for me.

@licaon-kter
Copy link
Contributor Author

Odd, will reattach asap

@licaon-kter
Copy link
Contributor Author

ee.ioc.phon.android.speak_1916.log.gz

this works now, does for you too?

@Kaljurand
Copy link
Owner

Thanks! I could download the error log now. Some of these errors seem familiar to me as lint warnings. It would take a while to work-around all of them, though...

One thing to try in the F-Droid build is to use my exact gradle.properties (https://github.com/Kaljurand/K6nele/blob/v1.9.16/gradle.properties):

android.defaults.buildfeatures.buildconfig=true
android.enableJetifier=false
android.nonFinalResIds=false
android.nonTransitiveRClass=false
android.useAndroidX=true
org.gradle.jvmargs=-Xmx2560m
org.gradle.unsafe.configuration-cache=true

or some subset of it, e.g.

android.nonFinalResIds=false
android.nonTransitiveRClass=false

seem related (https://stackoverflow.com/questions/76334499/error-constant-expression-required-android-studio).

@Kaljurand Kaljurand pinned this issue Mar 20, 2024
@licaon-kter
Copy link
Contributor Author

One thing to try in the F-Droid build is to use my exact gradle.properties

if they are in the tagged tree, they'll be used as expected

@Kaljurand
Copy link
Owner

Maybe I'm misunderstanding how the F-Droid build works, but this line there:

prebuild: echo "android.useAndroidX=true" > ../gradle.properties

seems to overwrite the existing gradle.properties with a single property assignment.

@licaon-kter
Copy link
Contributor Author

Indeed, that was used in past recipes, but now it was at fault

thanks https://gitlab.com/fdroid/fdroiddata/-/commit/02ea288aae152ec78e1e341b3c5993a761f435c4

@Kaljurand Kaljurand unpinned this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants