Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tap to paginate restricts one from tapping on ePub links when they are rendered under the gutters #2835

Closed
gmahomarf opened this issue Apr 8, 2024 · 6 comments
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@gmahomarf
Copy link
Contributor

What happened?

Tried to click on a link in an ePub, but it moved to the previous page instead.

Steps:

  • Open an ePub
  • Try to click a link that is rendered in the gutter areas

What did you expect?

I expected my click to go through the gutter to the link

Kavita Version Number - Don't see your version number listed? Then your install is out of date. Please update and see if your issue still persists.

0.7.14 - Stable

What operating system is Kavita being hosted from?

Linux

If the issue is being seen on Desktop, what OS are you running where you see the issue?

Windows

If the issue is being seen in the UI, what browsers are you seeing the problem on?

Firefox

If the issue is being seen on Mobile, what OS are you running where you see the issue?

None

If the issue is being seen on the Mobile UI, what browsers are you seeing the problem on?

No response

Relevant log output

No response

Additional Notes

This was working before #2471.

In the GIF below, you can see the links being underlined on mouseover when the text falls outside the gutter. When the text falls inside the gutter, nothing happens.
2024-04-08-17-43-07-ezgif com-optimize

@gmahomarf gmahomarf added the needs-triage Needs to be triaged by a developer and assigned a release label Apr 8, 2024
@YodaDaCoda
Copy link
Contributor

same fundamental issue as #2694, would similiarly be resolved by #2754

@gmahomarf
Copy link
Contributor Author

gmahomarf commented Apr 12, 2024

same fundamental issue as #2694

Agree. Will probably close this issue.

would similiarly be resolved by #2754

Disagree, since this still affects desktop clients, where swiping is less intuitive.

@majora2007 I never actually asked: what were the bugs introduced by #2061?

@majora2007
Copy link
Member

@gmahomarf I can't recall 100%, but I do recall a few things cropping up that I fixed afterwards. I think they were around highlighting and the overlay.

@gmahomarf
Copy link
Contributor Author

Closed as dupe of #2694

@gmahomarf gmahomarf closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@ShivamAmin
Copy link
Contributor

same fundamental issue as #2694

Agree. Will probably close this issue.

would similiarly be resolved by #2754

Disagree, since this still affects desktop clients, where swiping is less intuitive.

@majora2007 I never actually asked: what were the bugs introduced by #2061?

Hey, actually, commit 2fd756f1f4ed56950ffc3ad40545b08e4ee002f1 fixes the issue where when Tap To Paginate is enabled, and you have text underneath the invisible prev/next buttons that pop up. All you have to do once #2754 is reviewed and merged is to tap in the center of the page bringing up the menu, this will hide the buttons and you can then select/click text on the screen. I'll add this to #2694 as well.

@gmahomarf
Copy link
Contributor Author

All you have to do once #2754 is reviewed and merged is to tap in the center of the page bringing up the menu, this will hide the buttons and you can then select/click text on the screen.

I, personally, dislike the idea of having to do an extra click/tap. I'd rather have it work by just clicking on the link or text to select directly.

I'll keep an eye on #2754 regardless, since this will at least give me a workaround. Thanks for the info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
Development

No branches or pull requests

4 participants