Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Action bar 4/5 seems mixed up #164

Closed
psykzz opened this issue Jul 27, 2024 · 14 comments
Closed

[BUG] Action bar 4/5 seems mixed up #164

psykzz opened this issue Jul 27, 2024 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@psykzz
Copy link

psykzz commented Jul 27, 2024

Describe the bug
Action bar 4/5 seems mixed up in settings
AlwaysShow seems to be flipped.

Error Log
No log, but see attached video

2024-07-27.13-12-16.mp4

Versions (please complete the following information):

  • WoW: SoD
  • Addon [e.g. v0.13.1]

Additional context

@psykzz psykzz added the bug Something isn't working label Jul 27, 2024
@psykzz psykzz changed the title [BUG] [BUG] Action bar 4/5 seems mixed up Jul 27, 2024
@Karl-HeinzSchneider
Copy link
Owner

Hey,
I'm working on a rewrite of the active/hidden logic. See #165

I wrote about that in a comment on curseforge yesterday I think, theres a problem in the blizzard code that the extra actionbars 4/5 are linked together in the options, like you need to activate 4 before you can activate 5. I already have an idea to override that completely, and use my own logic like in the custom bars 6/7/8.

Greate report btw ❤

@Karl-HeinzSchneider
Copy link
Owner

Should be fixed with 0e07fc2

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Do you publish main as an alpha build? If so i could test this now and validate for you.

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Noticed you actually just made a release, which is even better.
So i can confirm 4 is needed for 5, but alwaysShow buttons is working as expected now!

@Karl-HeinzSchneider
Copy link
Owner

Do you publish main as an alpha build? If so i could test this now and validate for you.

Only sometimes, because the automatic update pipeline is only for releases right now.

But everything should work fine now, because I'm reusing the logic from Actionbar 6/7/8 to show/hide the bar; I just force the blizzard CVars and activate every actionbar, and then handle the visiblity from the config state.
Now every Actionbar should be independent from the others.

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Toggling bar 4 does still seem to hide bar 5, but thats acceptable.

@Karl-HeinzSchneider
Copy link
Owner

Toggling bar 4 does still seem to hide bar 5, but thats acceptable.

You mean toggleing them in the blizzard options, right?
Because I changed the logic so that the blizzard settings get overriden (every actionbar toggle to true), and DragonflightUI handles the Actionbars now, so you would set the visiblity in the DragonflightUI config.

@Karl-HeinzSchneider
Copy link
Owner

But ofc if you change the Blizzard options, they will be hidden again, but after /reload etc they will be set to true again. So you would ignore the blizzard options now.

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

You mean toggleing them in the blizzard options, right?

Unfortunately not.

2024-07-28.12-08-44.mp4

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Unrelated but its also hiding the stancebar after some updates, but it returns on a reload.

@Karl-HeinzSchneider
Copy link
Owner

Ah, you dont have the newest Version v0.13.2.

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Apologies i swore i had updated :|

@psykzz
Copy link
Author

psykzz commented Jul 28, 2024

Working great thank you!

@Karl-HeinzSchneider
Copy link
Owner

Haha, classic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants