Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Skills / Profession window #210

Closed
psykzz opened this issue Aug 10, 2024 · 6 comments · Fixed by #228
Closed

[Feature Request] Skills / Profession window #210

psykzz opened this issue Aug 10, 2024 · 6 comments · Fixed by #228
Assignees
Labels
enhancement New feature or request

Comments

@psykzz
Copy link

psykzz commented Aug 10, 2024

Is your feature request related to a problem? Please describe.

My problem is that I dislike having to bind a button for my professions.

Describe the solution you'd like

I would love to have an implementation that adds the profession buttons to the skills window, as it is in retail.
image

Additional context
I would suggest keeping the stat displays as they are but maybe showing them where archeology or other skills may be shown.

@psykzz psykzz added the enhancement New feature or request label Aug 10, 2024
@Karl-HeinzSchneider
Copy link
Owner

Hey,
you mean on the Spellbook, like Cata and Retail (extra window, but same style) has it? E.g.
image

I would like that, but its a good chunk of work, so don't count on it soon. But I'll add it to the roadmap.

@psykzz
Copy link
Author

psykzz commented Aug 15, 2024

Exactly yes.

@psykzz
Copy link
Author

psykzz commented Aug 16, 2024

@Karl-HeinzSchneider is there anything I could i could do to help?
Do you need help discovering assets, or just time spent putting UI together?

@Karl-HeinzSchneider
Copy link
Owner

@Karl-HeinzSchneider is there anything I could i could do to help? Do you need help discovering assets, or just time spent putting UI together?

I think if you're not really familiar with the codebase (WoW, and DragonflightUI), it might be difficult. I already have a good idea how to implement it, and already started putting it together:

image

@Karl-HeinzSchneider
Copy link
Owner

Style is done:
image

Now only cleanup, adding update events here and there, and adding the tab logic to the spellbook left. Should be ready this week.

@Karl-HeinzSchneider
Copy link
Owner

I merged it into main. Will be in v0.15.2 in max 1-2 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants