From 411596c07be30a0a7df21ea354766360f125893e Mon Sep 17 00:00:00 2001 From: Wick Date: Sun, 25 Feb 2024 20:17:30 +0800 Subject: [PATCH] chore(reactivity): replace console.warn() to warn function (#10394) --- packages/reactivity/src/collectionHandlers.ts | 5 +++-- packages/reactivity/src/reactive.ts | 3 ++- packages/reactivity/src/ref.ts | 3 ++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/reactivity/src/collectionHandlers.ts b/packages/reactivity/src/collectionHandlers.ts index 58e69b1cc..2b7785ae7 100644 --- a/packages/reactivity/src/collectionHandlers.ts +++ b/packages/reactivity/src/collectionHandlers.ts @@ -7,6 +7,7 @@ import { } from './reactiveEffect' import { ReactiveFlags, TrackOpTypes, TriggerOpTypes } from './constants' import { capitalize, hasChanged, hasOwn, isMap, toRawType } from '@vue/shared' +import { warn } from './warning' type CollectionTypes = IterableCollections | WeakCollections @@ -223,7 +224,7 @@ function createReadonlyMethod(type: TriggerOpTypes): Function { return function (this: CollectionTypes, ...args: unknown[]) { if (__DEV__) { const key = args[0] ? `on key "${args[0]}" ` : `` - console.warn( + warn( `${capitalize(type)} operation ${key}failed: target is readonly.`, toRaw(this), ) @@ -397,7 +398,7 @@ function checkIdentityKeys( const rawKey = toRaw(key) if (rawKey !== key && has.call(target, rawKey)) { const type = toRawType(target) - console.warn( + warn( `Reactive ${type} contains both the raw and reactive ` + `versions of the same object${type === `Map` ? ` as keys` : ``}, ` + `which can lead to inconsistencies. ` + diff --git a/packages/reactivity/src/reactive.ts b/packages/reactivity/src/reactive.ts index 8b94dd9a4..1e0f9365d 100644 --- a/packages/reactivity/src/reactive.ts +++ b/packages/reactivity/src/reactive.ts @@ -13,6 +13,7 @@ import { } from './collectionHandlers' import type { RawSymbol, Ref, UnwrapRefSimple } from './ref' import { ReactiveFlags } from './constants' +import { warn } from './warning' export interface Target { [ReactiveFlags.SKIP]?: boolean @@ -247,7 +248,7 @@ function createReactiveObject( ) { if (!isObject(target)) { if (__DEV__) { - console.warn(`value cannot be made reactive: ${String(target)}`) + warn(`value cannot be made reactive: ${String(target)}`) } return target } diff --git a/packages/reactivity/src/ref.ts b/packages/reactivity/src/ref.ts index 1b9d60ef0..5f40fbb7c 100644 --- a/packages/reactivity/src/ref.ts +++ b/packages/reactivity/src/ref.ts @@ -25,6 +25,7 @@ import type { ShallowReactiveMarker } from './reactive' import { type Dep, createDep } from './dep' import { ComputedRefImpl } from './computed' import { getDepFromReactive } from './reactiveEffect' +import { warn } from './warning' declare const RefSymbol: unique symbol export declare const RawSymbol: unique symbol @@ -345,7 +346,7 @@ export type ToRefs = { */ export function toRefs(object: T): ToRefs { if (__DEV__ && !isProxy(object)) { - console.warn(`toRefs() expects a reactive object but received a plain one.`) + warn(`toRefs() expects a reactive object but received a plain one.`) } const ret: any = isArray(object) ? new Array(object.length) : {} for (const key in object) {