feat: drop Node.js v10 and v12 support

BREAKING CHANGE: Node.js v10 and v12 are no longer supported.
kenany · Jun 25, 2022 · 1e727b9 · 1e727b9
1 parent 7a049fa
commit 1e727b9
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml
@@ -5,7 +5,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        node-version: [12, 14, 16]
+        node-version: [14, 16, 18]
         os: [ubuntu-latest]
     steps:
     - name: Node.js ${{ matrix.node-version }}

diff --git a/index.js b/index.js
@@ -1,6 +1,12 @@
+/** @type {Window} */
 var window = require('global/window');
 var nodeCrypto = require('crypto');
 
+/**
+ * @template {ArrayBufferView | null} T
+ * @param {T} buf
+ * @returns {T}
+ */
 function getRandomValues(buf) {
   if (window.crypto && window.crypto.getRandomValues) {
     return window.crypto.getRandomValues(buf);

diff --git a/package.json b/package.json
@@ -17,7 +17,7 @@
     "test": "test"
   },
   "engines": {
-    "node": "10 || 12 || >=14"
+    "node": "14 || 16 || >=18"
   },
   "scripts": {
     "release": "semantic-release",

diff --git a/test/index.js b/test/index.js
@@ -1,9 +1,10 @@
-var getRandomValues = require('../');
 var test = require('tape');
 var isFunction = require('lodash.isfunction');
 var forEach = require('lodash.foreach');
 var isBrowser = require('is-browser');
 
+var getRandomValues = require('../');
+
 test('exports a function', function(t) {
   t.plan(1);
   t.ok(isFunction(getRandomValues));
@@ -43,7 +44,7 @@ test('throws on length >65536', function(t) {
   }, new RegExp(/QuotaExceededError/));
 });
 
-test('returns arguement', function(t) {
+test('returns argument', function(t) {
   t.plan(1);
   var argument = new Uint8Array(1024);
   t.equal(getRandomValues(argument), argument);