Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace clang tidy gh action #463

Open
briaguya-ai opened this issue Apr 3, 2024 · 1 comment
Open

replace clang tidy gh action #463

briaguya-ai opened this issue Apr 3, 2024 · 1 comment

Comments

@briaguya-ai
Copy link
Collaborator

it has been nothing but problematic, worth looking into something like https://github.com/cpp-linter/cpp-linter-action

@briaguya-ai
Copy link
Collaborator Author

the crux of the issue is that the comments themselves are blocking the merge. a better way to handle this would be to have a clang tidy status check that fails when there are tidy changes requested (just like format does). i think the cpp-linter-action does that but i haven't done a deep dive into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant