Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem detecting site while comparing URLs in 'Detailed analysis of all rendered pages' module #89

Closed
ondrejsevcik opened this issue Mar 7, 2016 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@ondrejsevcik
Copy link
Contributor

The Detailed analysis of all rendered pages module is liable to error while querying the database. It's because of the SQL query (link to file)

SELECT s.SiteID 
FROM CMS_Site AS s 
LEFT JOIN CMS_SiteDomainAlias AS sa 
ON s.SiteID = sa.SiteID 
WHERE ('{0}' LIKE '%' + s.SiteDomainName + '%'
OR '{0}' LIKE '%' + sa.SiteDomainAliasName + '%') 
AND s.SiteStatus = N'RUNNING'

where the {0} part is replaced with values entered by user into the Target setup form. If the entered URL differs just in one character (e.g.: http://domain.com/ vs. http://domain.com) this module throws an error:

Error in "Detailed analysis of all rendered pages (takes a while)" module. Error message: Null object cannot be converted to a value type.

There should be some smarter logic to recognize the analyzed website.

@ondrejsevcik ondrejsevcik added the bug Something isn't working label Mar 7, 2016
@ondrejsevcik ondrejsevcik added this to the 3.1 milestone Mar 7, 2016
@ondrejsevcik ondrejsevcik modified the milestones: 3.3, 3.1 May 10, 2016
@ondrejsevcik ondrejsevcik removed this from the 3.3 milestone May 31, 2016
@ChristopherJennings ChristopherJennings added this to the 3.8 milestone Jun 15, 2017
@ChristopherJennings
Copy link
Contributor

This was re-reported in #131 and fixed in #136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants