-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings and increase deployment target to 10.13 for Xcode 14 #150
base: master
Are you sure you want to change the base?
Conversation
Fix deprecation warnings
Can you edit your title to say 10.13 instead of 10.3? Thank you |
@@ -1142,7 +1142,7 @@ - (void)_installEventHandlerIfNeeded | |||
{ kEventClassKeyboard, kEventHotKeyPressed }, | |||
{ kEventClassKeyboard, kEventHotKeyReleased } | |||
}; | |||
os_trace("Installing Carbon hot key event handler"); | |||
os_log_error(OS_LOG_DEFAULT, "Installing Carbon hot key event handler"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one shouldn't be an error, I believe.
@@ -1167,11 +1167,11 @@ - (void)_removeEventHandlerIfNeeded | |||
if (_disableCounter <= 0 && _shortcutToHotKeyRef.count) | |||
return; | |||
|
|||
os_trace("Removing Carbon hot key event handler"); | |||
os_log_error(OS_LOG_DEFAULT, "Removing Carbon hot key event handler"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one shouldn't be an error I believe.
return; | ||
} | ||
|
||
static UInt32 CarbonID = _SRInvalidHotKeyID; | ||
EventHotKeyID hotKeyID = {SRShortcutActionSignature, ++CarbonID}; | ||
os_trace("Registering Carbon hot key"); | ||
os_log_error(OS_LOG_DEFAULT, "Registering Carbon hot key"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one shouldn't be an error either.
Fixes #149
I replace
os_trace
withos_log
which causes a lot more logging in Xcode, but preserves the logging.os_log_debug
is too chatty for my taste, but I didn't want to be deleting existing logging either.