Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter package is not working #7

Open
radjivF opened this issue Jan 24, 2018 · 2 comments
Open

Counter package is not working #7

radjivF opened this issue Jan 24, 2018 · 2 comments

Comments

@radjivF
Copy link

radjivF commented Jan 24, 2018

screen shot 2018-01-24 at 2 20 59 pm
I got this error, any idea?

My react-native configuration:
"react": "16.2.0",
"react-native": "0.52.0",

Cheers

@azanli
Copy link

azanli commented Mar 5, 2018

The package has not been updated on NPM. Therefore, the recent proptypes fix is not included in the default library installed by npm install. So to include the changes, replace these imports:

import React, { Component, PropTypes } from 'react';
import React, { Component } from 'react';
import PropTypes from 'prop-types';

By the way, the library works great. Thank you for sharing this!

@davefreiman
Copy link

@Kerumen Love the package. The PR that fixed this has been merged but no release has been pushed to npm. Can you kindly do this so we can include a released version? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants